Skip to content

Bind shared JIT assignment values for OSR - #24643

Open
kairosci wants to merge 1 commit into
php:PHP-8.4from
kairosci:fix/gh-24214-jit-osr-bindings
Open

kairosci wants to merge 1 commit into
php:PHP-8.4from
kairosci:fix/gh-24214-jit-osr-bindings

Conversation

@kairosci

Copy link
Copy Markdown
Contributor

Fixes #24214 by binding copies of shared assignment values for JIT loop entry, following @ndossche's proposed fix. Adds integer and floating-point regression coverage. Local JIT suites pass on NTS and ZTS debug builds.

@kairosci
kairosci requested a review from dstogov as a code owner October 24, 2026 13:34
@kairosci
kairosci force-pushed the fix/gh-24214-jit-osr-bindings branch from e925112 to 10061db Compare October 29, 2026 15:28
@ndossche
ndossche requested a review from arnaud-lb November 1, 2026 11:09
@kairosci
kairosci force-pushed the fix/gh-24214-jit-osr-bindings branch from 10061db to ec720cd Compare November 1, 2026 13:27
@kairosci
kairosci force-pushed the fix/gh-24214-jit-osr-bindings branch 2 times, most recently from ba0d1cd to fd1ea3c Compare November 2, 2026 21:21
@kairosci
kairosci marked this pull request as draft November 3, 2026 07:57
@kairosci
kairosci marked this pull request as ready for review November 12, 2026 17:20
@kairosci
kairosci requested a review from bukka as a code owner November 12, 2026 17:20
@kairosci

Copy link
Copy Markdown
Contributor Author

cc @arnaud-lb

@kairosci
kairosci force-pushed the fix/gh-24214-jit-osr-bindings branch 2 times, most recently from f661d0a to 4ca051c Compare November 16, 2026 17:47
@kairosci kairosci changed the title Fix GH-24214: Bind shared JIT assignment values for OSR Bind shared JIT assignment values for OSR Nov 16, 2026
Fixes php#24214.

Co-authored-by: Nora Dossche <7771979+ndossche@users.noreply.github.com>
@kairosci
kairosci force-pushed the fix/gh-24214-jit-osr-bindings branch from 4ca051c to fd3bb82 Compare November 16, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant