Skip to content

fix(maintainers): make avatar loading states visible - #1506

Merged
manudeli merged 1 commit into
TanStack:mainfrom
manudeli:fix/maintainer-avatar-skeleton
Nov 15, 2026
Merged

manudeli merged 1 commit into
TanStack:mainfrom
manudeli:fix/maintainer-avatar-skeleton

Conversation

@manudeli

@manudeli manudeli commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Use the same avatar loading treatment in the maintainer cards, globe markers, and selected locations. Existing design-system neutral colors make the placeholder distinct from the page in light and dark modes.
  • Use the existing shimmer animation while an image is pending and fade in the photo after it decodes. Use a static placeholder for reduced motion or failed images.

Testing

  • Delayed and failed avatar responses in Chromium and checked full, compact, and row card layouts in both themes. Verified the image fades in without shifting the card, and that globe avatar requests are still deferred until needed.
  • pnpm test

Summary by CodeRabbit

  • New Features
    • Maintainer profile images now display a shimmer placeholder while loading and update when the image loads or fails.
    • Avatar loading can be deferred, and images support configurable dimensions and styling.
  • Improvements
    • Maintainer avatars across cards and the map now use consistent loading behavior and presentation.

@changeset-bot

changeset-bot Bot commented Nov 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8ef4aa7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request adds MaintainerAvatarImage, which tracks image loading and decoding outcomes and displays a shimmer placeholder. Maintainer cards and map avatars now use this shared component.

Changes: Maintainer avatar images

Layer / File(s) Summary
Shared image component
src/components/MaintainerAvatarImage.tsx
Adds an image component with optional deferred loading, dimensions, and styling. It handles load, error, and decode outcomes and renders a shimmer placeholder.
Maintainer card integration
src/components/MaintainerCard.tsx
Compact, row, and standard cards use the shared component instead of direct image elements. The standard card’s GitHub link no longer has its background color class.
Map avatar integration
src/components/MaintainersMap.tsx
Globe and selected-cluster avatars use the shared component. The globe avatar’s inline loading state and placeholder overlay are removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Suggested reviewers: tannerlinsley, tkdodo

Merge Risk: Minimal · up to 8ef4a

This change gives maintainer avatars a consistent loading placeholder and fade-in across cards and the globe. No concrete merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix(maintainers): make avatar loading states visible" matches the main change. The PR adds a shared MaintainerAvatarImage component that shows placeholders and a shimmer while avatars load,…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(maintainers): make avatar loading states visible" matches the main change. The PR adds a shared MaintainerAvatarImage component that shows placeholders and a shimmer while avatars load, and fades images in after decoding. The maintainer cards and globe markers now use this component. The title is specific and concise, and it names the scope (maintainers) and the type of change (fix).

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d3662d62-c8c6-4b89-bb5e-c8d575965223
Commits

Reviewing files that changed from the base of the PR and between fe0b1ba and 8ef4aa7.

Files selected for processing: 3

  • src/components/MaintainerAvatarImage.tsx
  • src/components/MaintainerCard.tsx
  • src/components/MaintainersMap.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@manudeli
manudeli merged commit a89b3fc into TanStack:main Nov 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant