You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(maintainers): make avatar loading states visible - #1506
Use the same avatar loading treatment in the maintainer cards, globe markers, and selected locations. Existing design-system neutral colors make the placeholder distinct from the page in light and dark modes.
Use the existing shimmer animation while an image is pending and fade in the photo after it decodes. Use a static placeholder for reduced motion or failed images.
Testing
Delayed and failed avatar responses in Chromium and checked full, compact, and row card layouts in both themes. Verified the image fades in without shifting the card, and that globe avatar requests are still deferred until needed.
pnpm test
Summary by CodeRabbit
New Features
Maintainer profile images now display a shimmer placeholder while loading and update when the image loads or fails.
Avatar loading can be deferred, and images support configurable dimensions and styling.
Improvements
Maintainer avatars across cards and the map now use consistent loading behavior and presentation.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
No actionable comments were generated in the recent review.
Walkthrough
The pull request adds MaintainerAvatarImage, which tracks image loading and decoding outcomes and displays a shimmer placeholder. Maintainer cards and map avatars now use this shared component.
Adds an image component with optional deferred loading, dimensions, and styling. It handles load, error, and decode outcomes and renders a shimmer placeholder.
Compact, row, and standard cards use the shared component instead of direct image elements. The standard card’s GitHub link no longer has its background color class.
This change gives maintainer avatars a consistent loading placeholder and fade-in across cards and the globe. No concrete merge-blocking risk was identified.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "fix(maintainers): make avatar loading states visible" matches the main change. The PR adds a shared MaintainerAvatarImage component that shows placeholders and a shimmer while avatars load,…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "fix(maintainers): make avatar loading states visible" matches the main change. The PR adds a shared MaintainerAvatarImage component that shows placeholders and a shimmer while avatars load, and fades images in after decoding. The maintainer cards and globe markers now use this component. The title is specific and concise, and it names the scope (maintainers) and the type of change (fix).
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: d3662d62-c8c6-4b89-bb5e-c8d575965223
Commits
Reviewing files that changed from the base of the PR and between fe0b1ba and 8ef4aa7.
Files selected for processing: 3
src/components/MaintainerAvatarImage.tsx
src/components/MaintainerCard.tsx
src/components/MaintainersMap.tsx
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pnpm testSummary by CodeRabbit