Skip to content

feat!: improve typing using phpstan drop phpunit < 11.5 - #15

Merged
SamMousa merged 2 commits into
masterfrom
cleanup
Sep 4, 2025
Merged

SamMousa merged 2 commits into
masterfrom
cleanup

Conversation

@SamMousa

@SamMousa SamMousa commented Sep 4, 2025

Copy link
Copy Markdown
Contributor
  • This drops support for older php versions
  • Drop support for phpunit < 11.5
  • Add static analysis
  • Set up automated releases
  • Remove the dependency on phpunit-wrapper.

@SamMousa
SamMousa merged commit 3680bd0 into master Sep 4, 2025
@SamMousa
SamMousa deleted the cleanup branch September 4, 2025 12:54
@github-actions

github-actions Bot commented Sep 4, 2025

Copy link
Copy Markdown

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jorrit

jorrit commented Nov 16, 2026

Copy link
Copy Markdown

This PR broke the fixes introduced in PR #11.

@W0rma

W0rma commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

This PR broke the fixes introduced in PR #11.

@jorrit Thank you for the hint - #21 should fix the phpdoc again.

W0rma added a commit to W0rma/lib-asserts that referenced this pull request Nov 16, 2026
Codeception copies module docblocks verbatim into generated actor
traits without their imports, so the short `ArrayAccess` name used in
assertArrayHasKey() and assertArrayNotHasKey() resolved to the
generated namespace. This brings back the problem from Codeception#10, which Codeception#11
had fixed and Codeception#15 accidentally undid.
@jorrit

jorrit commented Nov 16, 2026

Copy link
Copy Markdown

Thanks @W0rma , I hadn't expected such a fast response!

W0rma added a commit that referenced this pull request Nov 16, 2026
Codeception copies module docblocks verbatim into generated actor
traits without their imports, so the short `ArrayAccess` name used in
assertArrayHasKey() and assertArrayNotHasKey() resolved to the
generated namespace. This brings back the problem from #10, which #11
had fixed and #15 accidentally undid.
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 3.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants